ENH: Added jupyter-pytorch-notebook Dockerfile #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently pytorch notebook test is failing because the image is close to max cap of GitHub actions space provisions |
Neonbluestoplight
force-pushed
the
add_jupyter_pytorch_notebook
branch
from
31f292a to
15742c8
Compare
mamba was causing problems with pytorch CUDA compatibility so used pip for installing the required packages instead
Neonbluestoplight
force-pushed
the
add_jupyter_pytorch_notebook
branch
from
5fcecb7 to
3050395
Compare
lizsalmon
approved these changes
Nov 15, 2024
| fix-permissions "${CONDA_DIR}" && \ | ||
| fix-permissions "/home/${NB_USER}" | ||
| #switch back to jovyan to avoid accidental container runs as root | ||
| USER ${NB_UID} |
There was a problem hiding this comment.
Not sure if it changes anything but does it matter if this variable has the curly braces, whereas on line 11 it is written without them USER $NB_UID.
Otherwise it all looks good to me
There was a problem hiding this comment.
I don't think there is a difference between the two, but it keeps it consistent with how we switch back to user in our other dockerfiles
Dmitry-Popovichev
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs
pytorch,transformers,accelarate,bitsandbytesusing mamba