Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2889 extract non alloc arrays #2899

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Feb 14, 2025

Adds support for non-allocatable arrays in the driver extraction. I had to add a new generic interface with NonAlloc appended to the name. It adds support for is_allocatable for some types (as much as I needed), but only for arrays.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.89%. Comparing base (6afc06a) to head (a00b7aa).

Files with missing lines Patch % Lines
...clone/domain/lfric/lfric_extract_driver_creator.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2899      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files         359      359              
  Lines       51073    51091      +18     
==========================================
+ Hits        51021    51038      +17     
- Misses         52       53       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant