Centralize async callback storage in preparation for IPC/error handling #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echavemann
reviewed
Nov 12, 2024
echavemann
reviewed
Nov 12, 2024
echavemann
approved these changes
Nov 12, 2024
stevenewald
force-pushed
the
callbacks
branch
from
4293fd7 to
0b5802c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for error handling and IPC, which will both call async user callbacks. With the new ProcessCallbackStorage, simply adding a callback (now using etl::delegate) will cause it to eventually be triggered by the scheduler. Nice!
Aside: right now we're using the pattern of many things being a singleton, while another option is to have the scheduler own everything (hierarchy).
One could argue the latter is better practice because singletons can be messy, but I'd argue most(all?) of the singletons we have right now must be singletons (how could you have two button drivers? two schedulers?).
However, this makes visualizing dependencies (constr/deconstr and general call patterns) much harder.
In reality, it doesn't matter, just interesting to think about.