Merge pull request #1266 from stevencohn/1265-fix-arrange-containers

Fix arrange containers when no containers
stevencohn · Jan 18, 2024 · e767e96 · e767e96
2 parents 36af421 + 8e1df52
commit e767e96
Show file tree

Hide file tree

Showing 13 changed files with 84 additions and 9 deletions.
diff --git a/OneMore/Commands/Page/ArrangeContainersCommand.cs b/OneMore/Commands/Page/ArrangeContainersCommand.cs
@@ -11,6 +11,7 @@ namespace River.OneMoreAddIn.Commands
 	using System.Linq;
 	using System.Threading.Tasks;
 	using System.Xml.Linq;
+	using Resx = Properties.Resources;
 
 
 	/// <summary>
@@ -35,26 +36,34 @@ public ArrangeContainersCommand()
 
 		public override async Task Execute(params object[] args)
 		{
+			using var one = new OneNote(out page, out ns);
+
+			if (!page.Root.Elements(ns + "Outline").Any())
+			{
+				UIHelper.ShowInfo(Resx.ArrangeContainersCommand_noContainers);
+				return;
+			}
+
 			using var dialog = new ArrangeContainersDialog();
 			if (dialog.ShowDialog(owner) != System.Windows.Forms.DialogResult.OK)
 			{
 				return;
 			}
 
-			using var one = new OneNote(out page, out ns);
-
 			FindTopMargin();
 
-			if (dialog.Vertical)
+			var updated = dialog.Vertical
+				? ArrangeVertical(dialog.PageWidth)
+				: ArrangeFlow(dialog.Columns, dialog.PageWidth);
+
+			if (updated)
 			{
-				ArrangeVertical(dialog.PageWidth);
+				await one.Update(page);
 			}
 			else
 			{
-				ArrangeFlow(dialog.Columns, dialog.PageWidth);
+				UIHelper.ShowInfo(Resx.ArrangeContainersCommand_noContainers);
 			}
-
-			await one.Update(page);
 		}
 
 
@@ -79,10 +88,15 @@ private void FindTopMargin()
 		}
 
 
-		private void ArrangeVertical(int pageWidth)
+		private bool ArrangeVertical(int pageWidth)
 		{
 			var containers = CollectContainers(page, ns);
 
+			if (!containers.Any())
+			{
+				return false;
+			}
+
 			// find the topmost container position
 			var yoffset = Math.Min(
 				topMargin,
@@ -106,13 +120,20 @@ private void ArrangeVertical(int pageWidth)
 				var height = size.GetAttributeDouble("height");
 				yoffset += height + BottomMargin;
 			}
+
+			return true;
 		}
 
 
-		private void ArrangeFlow(int columns, int pageWidth)
+		private bool ArrangeFlow(int columns, int pageWidth)
 		{
 			var containers = CollectContainers(page, ns);
 
+			if (!containers.Any())
+			{
+				return false;
+			}
+
 			var xoffset = LeftMargin;
 
 			// find the topmost container position
@@ -161,6 +182,8 @@ private void ArrangeFlow(int columns, int pageWidth)
 				xoffset += Math.Max(width, colwidth) + RightMargin;
 				col++;
 			}
+
+			return true;
 		}
 
 

diff --git a/OneMore/Commands/Tagging/HashtagScanner.cs b/OneMore/Commands/Tagging/HashtagScanner.cs
@@ -184,6 +184,9 @@ public void Dispose()
 									dirtyPages++;
 								}
 							}
+
+							// throttle the workload to give breathing room to OneNote UI
+							await Task.Delay(100);
 						}
 
 						provider.DeletePhantoms(pids, sectionID, sectionPath);

diff --git a/OneMore/Properties/Resources.Designer.cs b/OneMore/Properties/Resources.Designer.cs
diff --git a/OneMore/Properties/Resources.ar-SA.resx b/OneMore/Properties/Resources.ar-SA.resx
@@ -288,6 +288,10 @@
     <value>أرشفة الموقع</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>لم يتم العثور على حاويات في هذه الصفحة</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>ترتيب الحاويات</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.de-DE.resx b/OneMore/Properties/Resources.de-DE.resx
@@ -285,6 +285,10 @@
     <value>Archivstandort</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>Auf dieser Seite wurden keine Container gefunden</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Container anordnen</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.es-ES.resx b/OneMore/Properties/Resources.es-ES.resx
@@ -288,6 +288,10 @@ OneNote se cerrará automáticamente</value>
     <value>Ubicación del archivo</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>No se encontraron contenedores en esta página.</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Organizar contenedores</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.fr-FR.resx b/OneMore/Properties/Resources.fr-FR.resx
@@ -285,6 +285,10 @@
     <value>Emplacement des archives</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>Aucun conteneur trouvé sur cette page</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Organiser les conteneurs</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.he-IL.resx b/OneMore/Properties/Resources.he-IL.resx
@@ -299,6 +299,10 @@ OneNote ייסגר אוטומטית</value>
     <value>מיקום ארכיון</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>לא נמצאו מיכלים בדף זה</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>מסדרים מיכלים</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.nl-NL.resx b/OneMore/Properties/Resources.nl-NL.resx
@@ -289,6 +289,10 @@ OneNote wordt automatisch gesloten</value>
     <value>Archieflocatie</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>Er zijn geen containers gevonden op deze pagina</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Containers schikken</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.pl-PL.resx b/OneMore/Properties/Resources.pl-PL.resx
@@ -297,6 +297,10 @@ OneNote zamknie się automatycznie</value>
     <value>Lokalizacja archiwum.</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>Na tej stronie nie znaleziono kontenerów</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Ułóż pojemniki</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.pt-BR.resx b/OneMore/Properties/Resources.pt-BR.resx
@@ -289,6 +289,10 @@ OneNote fechará automaticamente</value>
     <value>Localização do arquivo</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>Nenhum contêiner encontrado nesta página</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Organizar recipientes</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.resx b/OneMore/Properties/Resources.resx
@@ -299,6 +299,10 @@ OneNote will close automatically</value>
     <value>Archive Location</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>No containers found on this page</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>Arrange Containers</value>
     <comment>dialog title</comment>

diff --git a/OneMore/Properties/Resources.zh-CN.resx b/OneMore/Properties/Resources.zh-CN.resx
@@ -289,6 +289,10 @@ OneNote 将自动关闭</value>
     <value>档案位置</value>
     <comment>archive dialog title</comment>
   </data>
+  <data name="ArrangeContainersCommand_noContainers" xml:space="preserve">
+    <value>该页面未找到容器</value>
+    <comment>message</comment>
+  </data>
   <data name="ArrangeContainersDialog.Text" xml:space="preserve">
     <value>排列容器</value>
     <comment>dialog title</comment>