FIX: Escaping Problem of Passwords on Import #2165
Conversation
| //escape all passwords for shell | ||
| passwords = passwords.map((p) => { | ||
| let pass = p; | ||
| if (pass.includes('"')) pass = pass.replaceAll(/"/g, '\\"'); |
There was a problem hiding this comment.
Is it better to use a library to escape all potential special characters rather than manually escaping only some of them? For example: require('shell-escape')
There was a problem hiding this comment.
they're escaped by JSON.stringify. The main problem are the double and single quotes. And because JSON.stringify already does escaping i need to remove the extra \ introduced with '\'', which i use to escape single quotes because all other variants i tried didn't work. This means that some library wont help either. This was all more complex then i thought tbh 😅
There was a problem hiding this comment.
but i think there is another problem when the password includes \...
There was a problem hiding this comment.
so everthing should be fixed now 😅
fixes #2163