Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launcher.pyw #32

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

qurious-pixel
Copy link

Update to include the changes for smw_assets.dat

Description

Fixes launching for the smw_assets.dat

Reasons behind the change

Fixes #31

Will this Pull Request break anything?

no

Suggested Testing Steps

Needs additional testing for Windows with TCC

@ShizCalev
Copy link

ShizCalev commented Aug 9, 2024

Testing this PR on windows, #31 is fixed but there's a new issue, extract_assets.bat doesn't get executed & trying to open any of the games through the launcher results in this error.
image

Manually executing it resolves the issue.

@qurious-pixel
Copy link
Author

I made some additional changes that were not in this PR.
You could check my win_ci branch, or grab the files from here:

https://github.com/qurious-pixel/SMAS_Launcher/releases/tag/launcher

Copy link

@jjmakin jjmakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, after trying to build stephini's launcher and failing, I found yours via the pull requests and wanted to say thank you for this. I also submitted a pull request to them with newer python modules in the requirements for building against a slightly more modern python person. Are you more active than they are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Launcher boots with only error message at splash
3 participants