Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(discard) Fix documentation favicon, avatar image and background pattern. #66

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

josue
Copy link
Contributor

@josue josue commented Apr 14, 2020

Fixes PR #49

Preview:

@3p3r
Copy link
Contributor

3p3r commented Apr 14, 2020

@josue the gh-pages branch is what GH pages uses to deploy the documentation and it's not meant to be committed to directly. The documentation is generated by Docsify and automated by GH actions when you merge into master.

@josue
Copy link
Contributor Author

josue commented Apr 14, 2020

@3p3r ahh, yikes! 😱 i missed that, thanks!

@3p3r
Copy link
Contributor

3p3r commented Apr 14, 2020

no worries, honestly the gh-pages branch needs to be reset from scratch. it contains so much unnecessary files. it's confusing. I'll make a ticket for myself to fix it soon.

@josue josue changed the title Fix documentation favicon, avatar image and background pattern. (discard) Fix documentation favicon, avatar image and background pattern. Apr 14, 2020
@mneil
Copy link
Contributor

mneil commented Apr 20, 2020

I know this is closed but regarding the extra stuff in gh-pages the drone plugin force pushes everything - wiping out old files. I wouldn't be surprised if there was an option to do the same with the action I used. I'd start there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants