feat: consolidating AddHandler for RPC interface #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the functionality of the
AddHandler
and reflection methods in the RPC interface within thechassis
. The previous setup required a few different calls for the same amount of work and didn't support gRPC servers (as opposed to ConnectRPC) very well. The new pattern simplifies things so that you can do the following:I also removed the logger access as this shouldn't be managed at this layer. It should be managed at the handler layer instead and injected down from
main()
at instantiation.