Modify interface to also contain the interface from the envoy contr… #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSC208
force-pushed
the
andrew/chassis-grpc
branch
2 times, most recently
from
630bbbe to
18e6a0c
Compare
jgkawell
reviewed
Jul 11, 2024
jgkawell
reviewed
Jul 11, 2024
… plane go module, and add a way for the application service using the chassis direct access to the grpc server which is also needed for the envoy control plane mod
AndrewSC208
force-pushed
the
andrew/chassis-grpc
branch
from
468634c to
c7afc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
chassis.Loggerinterface to embed theLoggerinterface from the envoy control plane go module and add a way for the application service to use thegrpc.Serverwhich is also needed for the envoy control plane module. The changes are necessary to integratefuseandenvoy.