Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci_: set github codeowners for github workflows #6290

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

ci_: set github codeowners for github workflows #6290

wants to merge 2 commits into from
+1 −0

Conversation

igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Jan 28, 2025 •
edited by iurimatias
Loading

closes #6313

@igor-sirotin igor-sirotin requested review from fbarbu15 and a team January 28, 2025 11:35
@igor-sirotin igor-sirotin self-assigned this Jan 28, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 28, 2025 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c2fbd5a #1 2025-01-28 11:39:35 ~3 min ios 📦zip
✔️ c2fbd5a #1 2025-01-28 11:40:04 ~4 min macos 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:27 ~5 min linux 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:33 ~5 min macos 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:35 ~5 min windows 📦zip
✔️ c2fbd5a #1 2025-01-28 11:41:44 ~5 min android 📦aar
✔️ c2fbd5a #1 2025-01-28 11:42:43 ~6 min tests-rpc 📄log
✔️ c2fbd5a #1 2025-01-28 12:07:34 ~31 min tests 📄log
✔️ 4fa38b7 #2 2025-02-05 12:16:50 ~4 min macos 📦zip
✔️ 4fa38b7 #2 2025-02-05 12:19:04 ~7 min macos 📦zip
✔️ 4fa38b7 #2 2025-02-05 12:19:43 ~7 min ios 📦zip
✖️ 4fa38b7 #2 2025-02-05 12:23:22 ~11 min tests-rpc 📄log
✔️ 4fa38b7 #2 2025-02-05 12:25:50 ~14 min android 📦aar
✔️ 4fa38b7 #2 2025-02-05 12:26:11 ~14 min linux 📦zip
✔️ 4fa38b7 #2 2025-02-05 12:52:40 ~40 min tests 📄log

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.83%. Comparing base (06d2419) to head (c2fbd5a).
Report is 7 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6290      +/-   ##
===========================================
- Coverage    61.84%   61.83%   -0.01%     
===========================================
  Files          843      843              
  Lines       111287   111287              
===========================================
- Hits         68823    68815       -8     
- Misses       34497    34515      +18     
+ Partials      7967     7957      -10
Flag Coverage Δ
functional 21.56% <ø> (-0.07%) ⬇️
unit 60.32% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

@iurimatias iurimatias added this to the 2.33.0 Beta milestone Jan 30, 2025
@iurimatias iurimatias removed this from the 2.33.0 Beta milestone Jan 31, 2025
@yakimant
Copy link
Member

yakimant commented Feb 3, 2025

Can we add security team? FYI @0xM3R

@igor-sirotin
Copy link
Collaborator Author

Can we add security team? FYI @0xM3R

We can if @0xM3R finds it's necessary

jakubgs
jakubgs requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need security to review those.

@igor-sirotin igor-sirotin requested review from jakubgs and 0xM3R February 5, 2025 12:11
jakubgs
jakubgs reviewed Feb 5, 2025
View reviewed changes
.github/CODEOWNERS
@@ -9,6 +9,7 @@ shell.nix @status-im/devops
/_assets/ci/ @status-im/devops
/_assets/hooks/ @status-im/devops
/_assets/scripts/ @status-im/devops
/.github/workflows/ @status-im/devops @0xM3R
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have a security-internal team.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakubgs I was looking for such thing, but couldn't find it. The link you share is not opening for me 🤔

image

I would prefer a team tag as well, but not sure why this team is not available to tag. It doesn't appear for me in @ list either. Can you make this team somehow public?

Otherwise @0xM3R wasn't against adding him directly, we discussed this in DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs requested changes

@fbarbu15 fbarbu15 fbarbu15 approved these changes

@0xM3R 0xM3R Awaiting requested review from 0xM3R

Requested changes must be addressed to merge this pull request.

Assignees

@igor-sirotin igor-sirotin

Labels
core-team infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set github codeowners for github workflows
6 participants
@igor-sirotin @status-im-auto @yakimant @jakubgs @fbarbu15 @iurimatias