Respond to un-synced blocks request with ResourceUnavailable
#6977
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serving beacon blocks by range requests, there are three outcomes: 1. We have blocks available: Response is non-empty 2. The entire epoch actually is empty: Response is empty 3. We have not backfilled that far or have pruned the history To distinguish (2) from (3), send `ResourceUnavailable` if the requested range is for blocks earlier than our backfill progress.
tersec
reviewed
Mar 5, 2025
| @@ -233,8 +233,14 @@ p2pProtocol BeaconSync(version = 1, | |||
| raise newException(InvalidInputsError, "Empty range requested") | |||
|
|
|||
| var blocks: array[MAX_REQUEST_BLOCKS.int, BlockId] | |||
| let dag = peer.networkState.dag | |||
| if startSlot < dag.backfill.slot: | |||
| # Peers that are unable to reply to block requests within the | |||
There was a problem hiding this comment.
Appears to come from https://github.com/ethereum/consensus-specs/blob/v1.5.0-beta.2/specs/phase0/p2p-interface.md#responding-side which would be useful to link
etan-status
commented
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving beacon blocks by range requests, there are three outcomes:
To distinguish (2) from (3), send
ResourceUnavailableif the requested range is for blocks earlier than our backfill progress.