rm support for deprecated reqStep in req/resp

[tersec]

It also attempts to address the issue in https://github.com/status-im/nimbus-eth2/actions/runs/12829462835/job/35775570006 where after the update to nondeprecated upload-artifact@v4:

Run actions/upload-artifact@v4
  with:
    name: Unit Test Results linux-amd64
    path: build/*.xml
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
  env:
    PLATFORM: x64
    NIMFLAGS:  -d:limitStackUsage 
    ncpu: 12
    make_cmd: make
With the provided path, there will be 3 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

The CI had begun failing, and would fail consistently starting in a couple of weeks, using upload-artifact@v3, due to this deprecation. This @v3 version was relying on behavior intentionally changed in v4 and the maintainers are fairly adament that, no, there's no direct/drop-in way to use v4 in the v3 manner, nor should there be.

Regarding overwrite: false, it is possible to configure that to true, but actions/upload-artifact#506 suggests that doesn't adequately resolve this, and:

👋 I want to clarify that the overwrite operation is not atomic. It simply is a helper to delete the artifact before creating a new one.

The intended purpose of this overwrite feature was not for parallel jobs. It was meant for serial overwriting (like uploading a binary, then downloading it, signing it, then reuploading it).

The two linux-amd64 jobs are potentially functioning in this parallel manner. Enabling overwrite: true is a still-possible step, but not the most elegant or, apparently, robust, approach.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error presumably would just cause this not to be an error, but also, well.

scripts/repo_paths.sh was not used.

[github-actions]

Unit Test Results

       15 files    2 285 suites   1h 11m 28s ⏱️
  5 358 tests   5 011 ✔️ 347 💤 0 ❌
36 999 runs  36 509 ✔️ 490 💤 0 ❌

Results for commit 877b0c2.

♻️ This comment has been updated with latest results.