log engine/builder API decisionmaking #5608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is to be useful, it's not clear to me whether it has as much value at
debug
asinfo
.The general goal here is to clarify for for Nimbus end-users and for developers if/when Nimbus is properly comparing engine/builder bids and when it's inadvertently selecting one because the other didn't work. It furthermore shows even when selecting one, if both arrived, the value of the other bid as well.
I don't view this as critical functionality, but might be nice to have, and came up during some discussions/apropos concerns about what happened when Nimbus sometimes did not use a configured builder AP relay but fell back to the engine API
General reasons this can occur are relays being down, or more commonly, returning HTTP 204, indicating nothing interesting to suggest for that slot. It can also happen that they do suggest some block (header), but it's not particularly valuable.
The latter becomes potentially more interesting as the local block value boost is increased, because usually in a direct comparison, the builders and relays will create higher-value blocks than local EL clients, but might not if they have to be 15%+ higher-value.