Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump blscurve closes #2693 and #2695 #2700

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Jul 3, 2021

Bump nim-blscurve, closes #2693 #2695

Upstream description: status-im/nim-blscurve#115

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Unit Test Results

     28 files  ±0     328 suites  ±0   1h 8m 30s ⏱️ ±0s
   636 tests ±0     618 ✔️ ±0    18 💤 ±0  0 ❌ ±0 
3 484 runs  ±0  3 380 ✔️ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 38a5bc8. ± Comparison against base commit 38a5bc8.

♻️ This comment has been updated with latest results.

@mratsim mratsim merged commit 38a5bc8 into unstable Jul 6, 2021
@mratsim mratsim deleted the blscurve-pubkey-checks branch July 6, 2021 12:31
@arnetheduck
Copy link
Member

I'm not sure if we documented it clearly, but we do take some shortcuts crypto.nim - ie the deserialization from database is trusted, so we skip some checks to make startup faster - the thing that might be missing from the docs there might be how and where the preconditions are checked, ie that the publickey doesn't violate some nasty constraint

@mratsim
Copy link
Contributor Author

mratsim commented Jul 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants