Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eip4444 - Portal Integration #3087

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Eip4444 - Portal Integration #3087

wants to merge 11 commits into from
+274 −16

Conversation

advaita-saha
Copy link
Contributor

@advaita-saha advaita-saha commented Feb 18, 2025 •
edited
Loading

  • rpc level integration
  • common block serve through forkedchain
  • p2p serving ( dependency wire in forkedchain to p2p #3082 )
  • EIP-4444 specific block limit in p2p
  • cleanup + comments

kdeme
kdeme reviewed Feb 18, 2025
View reviewed changes
execution_chain/portal/portal.nim
proc rpcProvider*(pc: PortalClientRef): RpcClient =
pc.rpc.provider

proc toHeader(blkObj: BlockObject): Header =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you can use the native Portal JSON-RPC API that has the data in more convenient encoding than the EL JSON-RPC API.

We also have a helper JSON-RPC Nim API to access that easily here: https://github.com/status-im/nimbus-eth1/blob/master/fluffy/rpc/portal_rpc_client.nim

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did just notice that in that portal_rpc_client API we have not yet added the block header by number call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeme kdeme kdeme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@advaita-saha @kdeme