nrpc re-org handling #2994
Open
nrpc re-org handling #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Jan 13, 2025
tersec
reviewed
Jan 19, 2025
|
|
||
| info "newPayload Request sent", | ||
| blockNumber = int(payload.blockNumber), response = payloadResponse.status | ||
|
|
||
| if payloadResponse.status != PayloadExecutionStatus.valid: |
There was a problem hiding this comment.
This is too strict -- syncing and accepted are fine too.
This should trigger on what https://github.com/ethereum/consensus-specs/blob/v1.5.0-beta.0/sync/optimistic.md#helpers calls INVALIDATED: INVALID or INVALID_BLOCK_HASH.
There was a problem hiding this comment.
But syncing and accepted shouldn't be expected the behaviour if nrpc sync is running and syncing properly
There was a problem hiding this comment.
If the EL starts out as not synced, then in general an EL which does snap sync will go some hours before it starts responding with anything but syncing or accepted.
Lines 212 to 217 in cee5fe9
has a similar issue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds re-org handling capacity to
nrpcalong with fixes for #2796