Bugfix/nully values #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavurth
commented
Sep 16, 2022
Strip out unused JSON Update comment Remove echo Added DynamicBytes test More correct naming Remove one extra double check
tavurth
force-pushed
the
bugfix/nully-values
branch
from
db31b8f to
564f826
Compare
zah
reviewed
Sep 16, 2022
zah
reviewed
Sep 16, 2022
| var resUInt256Ref: ref UInt256 | ||
|
|
||
| # Nully values | ||
| should_be_value_error("null", resAddress) |
There was a problem hiding this comment.
As discussed in Discord, the most likely reason for the crashes in the object handling function in nim-json-rpc/jsonmarshal.nim, which is quite happy to propagate nil values to further calls to fromJson.
Your tests here are not covering it.
There was a problem hiding this comment.
Could you take a look at the tests added below?
tavurth
commented
Sep 17, 2022
arnetheduck
reviewed
Sep 21, 2022
|
@jangko I would suggest rebasing instead of merging master into this |
|
Well, I plan to squash them, so I think either way is fine. |
|
Yea, code guidelines & whatnot. Still, best practices are best practices Have fun 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing
nullor sometimes and empty string to certain value convertors anAssertionErrorwas raised, crashing my tests.I was seeing crashes when converting to
RlpEncodedBytesandTypedTransactionThis PR fixes the above, but I'm still looking into how exactly to inject JSON directly into the contract reader for a deeper level of testing.