Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-->> RDP Wrapper & Autoupdate (07-06-2020) #859

Closed
wants to merge 24 commits into from

Conversation

asmtron
Copy link

@asmtron asmtron commented Aug 12, 2019

RDP Wrapper & Autoupdate

Automatic RDP Wrapper installer and updater // asmtron (07-06-2020)

Info:

The Autoupdater (autoupdate.bat) first use and check the official rdpwrap.ini.
If a new termsrv.dll is not supported in the offical rdpwrap.ini,
autoupdater first tries the asmtron rdpwrap.ini. The autoupdater will also use rdpwrap.ini files
of other contributors. Extra rdpwrap.ini sources can also be defined...

autoupdate.bat Options:

  • -log = redirect display output to the file autoupdate.log
  • -taskadd = add autorun of autoupdate.bat on startup in schedule task
  • -taskremove = remove autorun of autoupdate.bat on startup in schedule task

Download and Install

NEWS

2020-12-06 -- add support for 10.0.19041.84 (x64)

Automatic RDP Wrapper installer and updater
….53 ...

additional termsrv.dll versions (disassembled and tested)
10.0.18362.267
10.0.18362.53
10.0.18362.1
10.0.17763.437
10.0.17763.379
10.0.17763.292
10.0.17763.165 x64
10.0.17134.706
force uninstall/reinstall of RDP Wrapper on a new version of termsrv.dll
add: check if installed termsrv.dll fileversion is different to the last saved termsrv.dll fileversion in registry; it detects all termsrv.dll version changes (for example from a windows update)
@PrplHaz4
Copy link

Thanks for writing this up @asmtron and including a PR. This seems to be a much safer way to distribute changes/updates to RDPwrap. Much better than linking to some random site with precompiled binaries...etc.

As it stands, the issues here could easily be (already are?) a vector for malware distribution, as people tend to just click, download and run.

It really is a shame none of this work is getting merged into the repo - clearly there are lots of people dependent on this wrapper being functional.

@binarymaster any chance of adding @asmtron and/or @saurav-biswas as a maintainer on the repo?

@junkwes
Copy link

junkwes commented Aug 12, 2019

Listener state: Not listening

bug: normal copy with admin right of the file "rdpwrap_new.ini" to "rdpwrap.ini" will not work properly (file locked)
fix: we need to stream the data line by line from "rdpwrap_new.ini" to "rdpwrap.ini"
add: listener check
@asmtron
Copy link
Author

asmtron commented Aug 13, 2019

Important -> autoupdate.bat **bugfix!

  1. bug: normal copy with admin right of the file "rdpwrap_new.ini" to "rdpwrap.ini" will not work properly (file locked)
  2. fix: we need to stream the data line by line from "rdpwrap_new.ini" to "rdpwrap.ini"
  3. add: listener check

With this bugfix autoupdate.bat works now as expected...

@asmtron asmtron changed the title new autoupdate batch file, rdpwrap.ini updates new autoupdate batch file **(bugfix), rdpwrap.ini updates Aug 13, 2019
@asmtron asmtron changed the title new autoupdate batch file **(bugfix), rdpwrap.ini updates new autoupdate batch file, rdpwrap.ini updates Aug 13, 2019
add: set "Network Level Authentication" in the windows registry
info: you can disable this feature by removing the two commands "call :setNLA" (line 207 and line 248)
@asmtron asmtron mentioned this pull request Aug 13, 2019
code optimization: speedup the file streaming by 600%
rdpwrap.ini - add support for termsrv.dll versions:
10.0.18362.267
10.0.18362.53
10.0.18362.1
10.0.17763.437
10.0.17763.379
10.0.17763.292
10.0.17763.165 x64
10.0.17134.706
(+saurav-biswas changes)
code optimization: speedup streaming rdpwrap_new.ini to rdpwrap.ini
@ericernie
Copy link

asmtron-rdpwrap.ini-02.09.2019.zip should work for 18362.267 ?
that number is not a heading in the ini though..

@AnDrEyKa-111
Copy link

AnDrEyKa-111 commented Feb 26, 2020

I think that all people have the same doubt because nobody knows the answer

All answers are in first post in this thread by Asmtron

@pelaooo
Copy link

pelaooo commented Feb 26, 2020

María. In spanish for you.
NO use otra ubicación para instalar / extraer los archivos RDP Wrapper.
USE SOLO el directorio "% ProgramFiles% \ RDP Wrapper" (normalmente C: \ Program Files \ RDP Wrapper)

  1. Copie los archivos / carpetas del archivo "autoupdate-v07.09.2019.zip" (o más reciente) en el directorio "% ProgramFiles% \ RDP Wrapper"

  2. Para habilitar la ejecución automática de autoupdate.bat en el inicio del sistema, ejecute el archivo por lotes del asistente de seguimiento como administrador:

    "% ProgramFiles% \ RDP Wrapper \ helper \ autoupdate__enable_autorun_on_startup.bat"

  3. Establezca en su Antivirus / WindowsDefnder una exclusión en la carpeta "% ProgramFiles% \ RDP Wrapper" para evitar la eliminación de archivos RDP Wrapper

  4. Ahora puede usar el archivo por lotes de actualización automática para instalar y actualizar el RDP Wrapper. Ejecute el siguiente archivo por lotes de actualización automática como administrador:

"% ProgramFiles% \ RDP Wrapper \ autoupdate.bat"

NOTA: Usa el autoupdate de AnDrEyKa-111.

@jonvickers
Copy link

def working on Win 10 Pro 1909 Term Srv 10.0.18362.657. Thank you!

@bxjxxyy
Copy link

bxjxxyy commented Apr 24, 2020

My system is useing termsrv.dll version : 10.0.18362.657
So I copied rdpwrap.ini and replace mine.
Then I got this problem:
image
image
Everything is correct,but I still can't login.Tried restart computer

@fragtion
Copy link

10.0.17763.771 ?

@asmtron asmtron changed the title new autoupdate batch file, rdpwrap.ini updates RDP Wrapper & Autoupdate Jun 12, 2020
@asmtron asmtron changed the title RDP Wrapper & Autoupdate -->> RDP Wrapper & Autoupdate Jun 12, 2020
@asmtron asmtron changed the title -->> RDP Wrapper & Autoupdate -->> RDP Wrapper & Autoupdate (07-06-2020) Jun 12, 2020
@pepepl
Copy link

pepepl commented Jun 19, 2020

Uncheck "Single session per user"

@Paramofidar
Copy link

Paramofidar commented Jun 19, 2020

Below Link Worked Perfectly without any special efforts... Special Thanks to @asmteon and All Team Members

https://github.com/asmtron/rdpwrap/blob/master/binary-download.md

with Win10 2004 or may 2020 update

@jwaschkau
Copy link

@asmtron Works for me with Win May 2020 update. Thanks for your work.

@asmtron
Copy link
Author

asmtron commented Sep 6, 2020

new pull request: #1160

@gitgotgone
Copy link

Is this still being updated/maintained? In the bat file, there are two sources of updated ini files. The second one is
https://raw.githubusercontent.com/saurav-biswas/rdpwrap-1/patch-1/res/rdpwrap.ini
This one hasn't been updated since 2019.
The first one, referencing the personal @asmtron repository, is
https://raw.githubusercontent.com/asmtron/rdpwrap/master/res/rdpwrap.ini
But that file has a header that says:
Updated=2021-10-07
Which is 2 weeks into the future...
I assume this is a typo, and it is supposed to be 2021-07-10, which is 2 months ago. There has been a major Windows update since then, e.g. Win 10 OS build 19042.1237.

@affinityv
Copy link

There is mine too INI, it gets updated regularly. I mostly rely upon @sebaxakerhtc to create the correct x64 section. Most people use x64, but some need x86. Whenever there is a new version, then both termsrv.dll files need to be uploaded here so that the settings can be worked out.

@gitgotgone
Copy link

Ah--I was using an old version of the autoupdater. I see now there are a bunch of new sources, including yours, @affinityv !
set rdpwrap_ini_update_github_1="https://raw.githubusercontent.com/asmtron/rdpwrap/master/res/rdpwrap.ini"
set rdpwrap_ini_update_github_2="https://raw.githubusercontent.com/sebaxakerhtc/rdpwrap.ini/master/rdpwrap.ini"
set rdpwrap_ini_update_github_3="https://raw.githubusercontent.com/affinityv/INI-RDPWRAP/master/rdpwrap.ini"
set rdpwrap_ini_update_github_4="https://raw.githubusercontent.com/DrDrrae/rdpwrap/master/res/rdpwrap.ini"
set rdpwrap_ini_update_github_5="https://raw.githubusercontent.com/saurav-biswas/rdpwrap-1/master/res/rdpwrap.ini"

Does the newest version you got from @sebaxakerhtc work with 19042.1237 (Win 10 Pro x64 v20H2)? I don't see it listed in any of the above ini. I only see a lot of .1000 versions, which I think are windows preview versions.

@affinityv , please see:
#1520
for an ini that does work with 1237. Maybe post it? Thanks!

@affinityv
Copy link

Does the newest version you got from @sebaxakerhtc work with 19042.1237 (Win 10 Pro x64 v20H2)? I don't see it listed in any of the above ini. I only see a lot of .1000 versions, which I think are windows preview versions.

Yes, it is a 1202 ... it's the termsrv.dll version that counts, not the Windows 10 version.

@gitgotgone
Copy link

Excellent--duh, thanks for explaining!

@gjuecat
Copy link

gjuecat commented Oct 23, 2021

does anybody have an update for 21H2 19044.1288? this version is not supported at the moment

@affinityv
Copy link

does anybody have an update for 21H2 19044.1288? this version is not supported at the moment

What is the termsrv.dll version?

@gjuecat
Copy link

gjuecat commented Nov 11, 2021

termsrv.dll Version 10.0.19041.1348

@Paramofidar
Copy link

Paramofidar commented Nov 12, 2021 via email

@affinityv
Copy link

termsrv.dll Version 10.0.19041.1348

That one is certainly covered in my INI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.