Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Add namespaceQuotasConfiguration to helm template #1760

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

anshul98ks123
Copy link
Collaborator

Issue(s)

thirdeye tasks limit per month

Description

Adding namespaceQuotasConfiguration to helm templates
ThirdEye Free Tier Usage Quota

It is used to enable the feature to set monthly quota for detection and notification tasks per namespace

How to test

Validate helm install locally
cd kubernetes/helm/startree-thirdeye

helm install --generate-name . --debug --dry-run
helm-install-default.txt

helm install --generate-name . --debug --dry-run --set defaultWorkspaceConfiguration.namespaceQuotasConfiguration.taskQuotasConfiguration.maximumDetectionTasksPerMonth=3100 --set defaultWorkspaceConfiguration.namespaceQuotasConfiguration.taskQuotasConfiguration.maximumNotificationTasksPerMonth=20000
helm-install-with-overrides.txt

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 0:26am

Copy link
Collaborator

@cyrilou242 cyrilou242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's add a config in config/server.yaml too
can be done in another PR

@anshul98ks123 anshul98ks123 merged commit 68c064d into master Jan 20, 2025
12 checks passed
@anshul98ks123 anshul98ks123 deleted the TE-helm-update branch January 20, 2025 13:51
@anshul98ks123
Copy link
Collaborator Author

LGTM, let's add a config in config/server.yaml too can be done in another PR

Ack, will add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants