Feature/assignment builder 1 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a thought: would it make it easier for review to break up Ivan's commits? |
|
|
||
| from instructor.compiler import * | ||
|
|
||
| print preview_as_json(1L) |
There was a problem hiding this comment.
Yeah, remove this please. And I made it to the bottom of my first read through!!!! Yay!
annagav
force-pushed
the
feature/assignment_builder_1
branch
from
903ee9e to
d8db895
Compare
|
Should be ready for review now! |
|
I think this is as good as it's going to get. Do you think we should squash the commits? Ivan's commit history isn't terribly enlightening, but it's something. Your call -- you can merge after you squash or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ivan's Assignment Builder.