Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add the limit of state diff size to limits-and-triggers.adoc #1479

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

XavierOP877
Copy link

@XavierOP877 XavierOP877 commented Jan 12, 2025

Description of the Changes

Added missing documentation for limit of state diff size limits-and-triggers section, following the established AsciiDoc format.
Related Issue:- #1321

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-1479/tools/limits-and-triggers/

Check List

  • ✅ Changes made against main branch and PR does not conflict
  • ✅ PR title is meaningful
  • ✅ Detailed description added
  • ✅ Specific URL(s) added

This change is Reviewable

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1479/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1479/ .

1 similar comment
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1479/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1479/ .

@XavierOP877
Copy link
Author

@LandauRaz please review the changes

@LandauRaz
Copy link
Collaborator

Hey @XavierOP877, thanks for the contribution and for following the checklist! I'll TAL at this ASAP 🙂

@XavierOP877
Copy link
Author

@LandauRaz any updates

@LandauRaz
Copy link
Collaborator

Hey @XavierOP877, I'm still waiting on some information from our engineers, but I'll hopefully have a final answer tomorrow 🙂

@XavierOP877
Copy link
Author

Hey @LandauRaz any updates?

@LandauRaz
Copy link
Collaborator

LandauRaz commented Jan 16, 2025

Hey @XavierOP877 , thanks for the ping and apologies for the delay. It seems 4,000 is the number of felts, and in terms of updates (key-value) it's 2,000. Are you able to make the necessary changes?

@LandauRaz LandauRaz self-requested a review January 16, 2025 21:42
@@ -48,6 +48,10 @@ The gas limit for Starknet blocks is therefore inherited from the gas limit for
This limit is important for ensuring the efficient execution of transactions and preventing potential congestion.
| 10,000,000 | 10,000,000

|Max state diffs per transaction|The maximum number of storage updates (state differences) that a single transaction can generate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants