SNIP-6 Update #130
Open
SNIP-6 Update #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnordelo
reviewed
Jan 20, 2025
Co-authored-by: Eric Nordelo <[email protected]>
gaetbout
reviewed
Jan 20, 2025
gaetbout
reviewed
Jan 20, 2025
Co-authored-by: gaetbout <[email protected]>
gaetbout
reviewed
Jan 20, 2025
gaetbout
reviewed
Jan 20, 2025
ericnordelo
reviewed
Jan 20, 2025
Co-authored-by: gaetbout <[email protected]>
Co-authored-by: gaetbout <[email protected]>
gaetbout
reviewed
Jan 20, 2025
ericnordelo
reviewed
Jan 21, 2025
Co-authored-by: Eric Nordelo <[email protected]>
gaetbout
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SNIP-6 to make sure the SRC5 interface ID doesn't change even if we do some small changes to the SNIP. Otherwise it's a problem to check if a given contract is an account
This PR also reflects the changes from
ArraytoSpanthat happened months ago when cairo was updatedLastly. This introduces a change to the
__execute__method. Today it returns the results of the calls. but the returned data is unusable. Specially since it’s now enforced that nobody can call__execute__directly. It's wasteful to generate and return all this data for nothing. The change shouldn't break anything and it can improve the performance of Starknet