Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mongoose 8 #154

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Support Mongoose 8 #154

merged 7 commits into from
Jan 4, 2024

Conversation

vkarpov15
Copy link
Collaborator

What this PR does:

Adds support for Mongoose 8. The big change between Mongoose 7 and Mongoose 8 as far as stargate-mongoose is concerned is that Mongoose 8 expects the underlying driver to return the document from findOneAndUpdate(), etc. unless includeResultMetadata is explicitly set to false. I made a slight switch for this in the driver layer using an IS_MONGOOSE_7 flag.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@vkarpov15 vkarpov15 requested a review from a team as a code owner November 23, 2023 21:39
Copy link
Contributor

@Yuqi-Du Yuqi-Du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kathirsvn
Copy link
Contributor

@vkarpov15 Can this PR be merged?

@vkarpov15 vkarpov15 merged commit 87f523b into main Jan 4, 2024
3 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/mongoose-8 branch January 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants