Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test coverage for #83 #144

Merged
merged 1 commit into from
Oct 31, 2023
Merged

add test coverage for #83 #144

merged 1 commit into from
Oct 31, 2023

Conversation

vkarpov15
Copy link
Collaborator

What this PR does:

Test to prove that #83 is fixed. We don't have an explicit batchSize parameter for now, which is fine, but we at least don't load the entire result set into memory. Just max pageSize at a time if using next().

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@vkarpov15 vkarpov15 requested a review from a team as a code owner October 13, 2023 14:48
@vkarpov15 vkarpov15 requested a review from kathirsvn October 13, 2023 14:48
@vkarpov15 vkarpov15 mentioned this pull request Oct 13, 2023
Closed
kathirsvn
kathirsvn approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@kathirsvn kathirsvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kathirsvn kathirsvn merged commit b6b0489 into main Oct 31, 2023
@kathirsvn kathirsvn deleted the vkarpov15/gh-83 branch October 31, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathirsvn kathirsvn kathirsvn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @kathirsvn