Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(sdk): support new typing hint example for transformers 4.36.0+ #3116

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request sdk 🐶 labels Jan 8, 2024
@tianweidut tianweidut self-assigned this Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (554441f) 82.83% compared to head (d3f0c19) 92.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3116      +/-   ##
============================================
+ Coverage     82.83%   92.01%   +9.17%     
============================================
  Files           575      139     -436     
  Lines         32075    16227   -15848     
  Branches       1866        0    -1866     
============================================
- Hits          26570    14931   -11639     
+ Misses         4680     1296    -3384     
+ Partials        825        0     -825     
Flag Coverage Δ
console ?
controller ?
standalone 92.01% <100.00%> (-0.06%) ⬇️
unittests 92.01% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 40f67ae into star-whale:main Jan 9, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ❤️ New feature or request sdk 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants