-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP enhancement(controller): add type for step spec #3076
base: main
Are you sure you want to change the base?
WIP enhancement(controller): add type for step spec #3076
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
============================================
- Coverage 82.70% 73.40% -9.30%
+ Complexity 3211 3192 -19
============================================
Files 571 436 -135
Lines 31789 15866 -15923
Branches 1873 1873
============================================
- Hits 26290 11647 -14643
+ Misses 4677 3393 -1284
- Partials 822 826 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
class StepType(Enum): | ||
evaluation = 'EVALUATION' | ||
fine_tune = 'FINE_TUNE' | ||
serving = 'SERVING' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we add plain
or customized
type for @handler
annotation
@@ -105,6 +106,7 @@ def register( | |||
require_dataset: bool = False, | |||
built_in: bool = False, | |||
fine_tune: FineTune | None = None, | |||
typ: StepType | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mabe typo for type: StepType
Description
TODO list:
Modules
Checklist