Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix broken resource ls cmd #2969

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working client 🌈 e2e labels Nov 13, 2023
@jialeicui jialeicui marked this pull request as draft November 13, 2023 07:50
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2969 (7835ed3) into main (dcc5c61) will increase coverage by 8.98%.
The diff coverage is 53.84%.

@@             Coverage Diff              @@
##               main    #2969      +/-   ##
============================================
+ Coverage     83.04%   92.03%   +8.98%     
============================================
  Files           558      123     -435     
  Lines         30395    15067   -15328     
  Branches       1818        0    -1818     
============================================
- Hits          25242    13867   -11375     
+ Misses         4347     1200    -3147     
+ Partials        806        0     -806     
Flag Coverage Δ
console ?
controller ?
standalone 92.03% <53.84%> (-0.13%) ⬇️
unittests 92.03% <53.84%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/starwhale/base/uri/project.py 98.21% <100.00%> (-0.10%) ⬇️
client/starwhale/core/dataset/view.py 75.87% <ø> (ø)
client/starwhale/core/runtime/view.py 80.97% <ø> (ø)
client/starwhale/base/view.py 80.99% <71.42%> (-0.29%) ⬇️
client/starwhale/core/model/view.py 71.09% <20.00%> (-0.74%) ⬇️

... and 441 files with indirect coverage changes

@jialeicui jialeicui force-pushed the fix-cli branch 2 times, most recently from a496800 to 8153301 Compare November 13, 2023 09:36
@jialeicui jialeicui marked this pull request as ready for review November 13, 2023 11:05
@jialeicui jialeicui merged commit cc1326b into star-whale:main Nov 15, 2023
@jialeicui jialeicui deleted the fix-cli branch November 15, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈 e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants