Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix desc not null #2968

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren requested a review from waynelwz November 13, 2023 07:14
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2968 (4415609) into main (0208100) will decrease coverage by 8.93%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2968      +/-   ##
============================================
- Coverage     83.05%   74.13%   -8.93%     
- Complexity     3105     3106       +1     
============================================
  Files           557      431     -126     
  Lines         30340    15104   -15236     
  Branches       1814     1753      -61     
============================================
- Hits          25199    11197   -14002     
+ Misses         4337     3106    -1231     
+ Partials        804      801       -3     
Flag Coverage Δ
console ?
controller 74.13% <ø> (-0.02%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 128 files with indirect coverage changes

Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit e6ef1fe into star-whale:main Nov 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants