Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor agreement frontend #3258

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Refactor agreement frontend #3258

merged 2 commits into from
Jan 9, 2025

Conversation

yifanmai
Copy link
Collaborator

@yifanmai yifanmai commented Jan 8, 2025

Refactor the code to move all scenario name matching to two central locations. Also add EWoK to the list of encrypted scenarios.

@yifanmai yifanmai requested a review from liamjxu January 8, 2025 23:59
@yifanmai yifanmai merged commit 40675ca into main Jan 9, 2025
3 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-agreement-refactor branch January 9, 2025 00:00
Copy link
Contributor

@liamjxu liamjxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yifanmai
Copy link
Collaborator Author

yifanmai commented Jan 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants