Update Bison to fix Clang error #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanoKobalamyne
force-pushed
the
bison-update-clang-error
branch
from
fc2b4e9 to
dc41d9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 16 made implicit function pointer conversions in C an error (they previously emitted a warning). Bison bundles
gnulib, which has a file (lib/objstack.c) that violates this in earlier versions. This got fixed with 0cc3971. Bison pulled this fix in in 98c35e0, which is first included in version 3.7.4.We currently download Bison 3.7 in the contrib script, but the latest macOS image on GitHub has Clang, so this causes errors is CI. Therefore, this PR updates Bison to 3.7.4.
Also see https://code.videolan.org/videolan/vlc/-/merge_requests/2399 for a similar change.