Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add novae.csv #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add novae.csv #46

wants to merge 1 commit into from

Conversation

tgrosson
Copy link

@tgrosson tgrosson commented Jan 3, 2022

Created for 60 fps, but 30 works

@d-albrecht
Copy link
Contributor

So simple, but still awesome! I like it.

But, can you give a explanation for why the already fading colors blink/flash once more in most of the patterns (but not all)? Is that an error in the calculation or is there something like this in novae?

@tgrosson
Copy link
Author

tgrosson commented Jan 4, 2022

Yeah... Mostly I just didn't feel like debugging it. It's definitely not a physically accurate representation of novae, more just an inspiration.

@d-albrecht
Copy link
Contributor

The most interesting aspect for me is that this doesn't happen for every explosion. If you ever decide to debug it, I would start there.

May I ask, was this somehow inspired by my submission? Because there are some similarities. I'm not trying to claim any authorship or such, just saying that I could see someone coming up with this one after they saw mine and given they already work in this field or are interested in these phenomena. And the ideas are clearly very different, only the look is alike to some extends. (And to prevent a situation that I don't want to cause: please don't close this PR just because mine has some similarities, I just had to deal with someone taking my comments to personally today already, I don't need another discouraged contributor, I wholeheartedly like this one)

@tgrosson
Copy link
Author

tgrosson commented Jan 5, 2022

Ah, no, I actually hadn't seen yours, but now that I have I can understand your thoughts. No, I just thought this might be a cool effect, vaguely influenced my background in astronomy.

For the brightening, I think it only happens when one explosion hasn't fully dimmed before the next one begins, and my conditions for how the lights are colored were kinda sloppy (just a long line of if...else's). My guess is that I just screwed up one of these statements slightly or didn't account for some condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants