Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/action to schema #2657

Merged
merged 8 commits into from
Feb 7, 2025
Merged

Feat/action to schema #2657

merged 8 commits into from
Feb 7, 2025

Conversation

tobi-bams
Copy link
Collaborator

Ticket №:

closes #2621 and #2622

Problem:

Screen.Recording.2025-02-04.at.21.01.32.mov

@tobi-bams tobi-bams requested a review from Rassl February 4, 2025 20:17
@tomsmith8
Copy link
Contributor

@tobi-bams added comments:

For 3D selected view, we should use the components already here (thanks for adding to 2D view):
sphinx tue 04 feb 08 40 48

For the Dropdown, we should use this components and render the list of actions on the schema here:
sphinx tue 04 feb 08 40 50

@tobi-bams
Copy link
Collaborator Author

Screen.Recording.2025-02-05.at.18.36.54.mov

@tomsmith8

@tomsmith8
Copy link
Contributor

@tobi-bams the cancel button is in a different style to the (e.g rounded corners) to the confirm button at the end.

To be honest, we probably don't need that extra model anyway?

@tomsmith8
Copy link
Contributor

@tobi-bams I missed https://github.com/stakwork/sphinx-nav-fiber/blob/62cdec3ee6dc8ed549302ea160438d393f8e5de9/src/components/ModalsContainer/CreateBountyModal/Body/index.tsx#L44

We need to send the JWT too

@tobi-bams
Copy link
Collaborator Author

Screen.Recording.2025-02-06.at.23.44.03.mov

@tomsmith8

@tomsmith8
Copy link
Contributor

maybe just standard success message.

"Submitted"

@tomsmith8
Copy link
Contributor

the second 2D is a bit strange.

it should be the same dropdown and button style as the first or just drop it for now

@tomsmith8
Copy link
Contributor

Maybe this is ok to merge and fix the 2D view in a second PR @tobi-bams @Rassl

@Rassl Rassl merged commit 9aa1bb5 into master Feb 7, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Actions into the SchemaStore
3 participants