Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hollerith constants inside Format statement #129

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

jgonzac
Copy link
Contributor

@jgonzac jgonzac commented Feb 20, 2025

This implementation tries to parse specifically the n characters in the Hollerith Constant instead of assuming some stop characters which can be valid inside the constant.

@jgonzac jgonzac force-pushed the fix-hollerith-in-format-stmt branch from b84a215 to ac56867 Compare February 21, 2025 12:51
Copy link
Collaborator

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jgonzac! Could maybe add a test of the splitting tokens over line continuations?

@jgonzac jgonzac force-pushed the fix-hollerith-in-format-stmt branch from ac56867 to 1bc1d17 Compare February 26, 2025 16:19
@jgonzac
Copy link
Contributor Author

jgonzac commented Feb 26, 2025

LGTM, thanks @jgonzac! Could maybe add a test of the splitting tokens over line continuations?

Done. I added some cases in test/corpus/line_continuations.txt.

@ZedThree ZedThree merged commit 765d82a into stadelmanma:master Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants