Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent node for procedure bindings and enumerator initialisation #124

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

ZedThree
Copy link
Collaborator

@ZedThree ZedThree commented Jan 7, 2025

Previously it was hard to iterate over all the methods in a
procedure_statement as procedure aliases were at the same level.

This is a similar change to variable declarations, where adding a
new parent node made it easier to iterate over init declarations.

Also making this a field for consistency with variable declarations

(includes #123)

Also allow capturing semicolons as unnamed literal node
Previously it was hard to iterate over all the methods in a
`procedure_statement` as procedure aliases were at the same level.

This is a similar change to variable declarations, where adding a
new parent node made it easier to iterate over init declarations.

Also making this a field for consistency with variable declarations
@ZedThree
Copy link
Collaborator Author

ZedThree commented Jan 7, 2025

Maybe just binding instead of declarator?

@ZedThree ZedThree changed the title Add parent node for procedure bindings Add parent node for procedure bindings and enumerator initialisation Jan 8, 2025
This is useful to be able to easily distinguish `generic` and `final`
procedures
@stadelmanma
Copy link
Owner

Maybe just binding instead of declarator?

I'm indifferent here in terms of naming, is this ready to merge?

@ZedThree
Copy link
Collaborator Author

Yep, now ready to merge, thanks!

@stadelmanma
Copy link
Owner

Thanks!

@stadelmanma stadelmanma merged commit 5fc069e into master Jan 14, 2025
1 check passed
@ZedThree ZedThree deleted the declarator-field-for-procedure-statements branch February 7, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants