Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S2C #182

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Add S2C #182

merged 2 commits into from
Feb 4, 2025
+4 −0

Conversation

777arc
Copy link
Contributor

@777arc 777arc commented Jan 25, 2025 •
edited
Loading

Also added D, even though it doesnt exist yet, just for good measure =P

@ircwaves
Copy link
Collaborator

ircwaves commented Feb 3, 2025

@777arc -- This does look like the fix needed. I know this is a small change, but mind adding an entry to CHANGELOG.md? Thanks!

ircwaves
ircwaves approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, with @gadomski's bump of the CI buttons here, it seems like the CHANGELOG entry can come later. The CI and packaging probably needs some love before a release can be cut.

@gadomski gadomski enabled auto-merge (squash) February 4, 2025 20:24
@gadomski gadomski merged commit 75eca32 into stactools-packages:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ircwaves ircwaves ircwaves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@777arc @ircwaves @gadomski