Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insert): add #106

Merged
merged 1 commit into from
Nov 16, 2016
Merged

feat(insert): add #106

merged 1 commit into from
Nov 16, 2016

Conversation

yoshuawuyts
Copy link
Contributor

@yoshuawuyts yoshuawuyts commented Nov 8, 2016

wip; adds sheetify/insert which would be used to remove the need for peer dependencies (and all its annoyances like not being installed by default and throwing warnings all over npm) - ref #105

todos

  • write implementation
  • fix tests (one's annoying-ish, but think regexes can help us :D)

@codecov-io
Copy link

codecov-io commented Nov 15, 2016

Current coverage is 96.00% (diff: 100%)

Merging #106 into master will not change coverage

@@             master       #106   diff @@
==========================================
  Files             2          2          
  Lines           150        150          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            144        144          
  Misses            6          6          
  Partials          0          0          

Powered by Codecov. Last update e0cb38d...284fd05

@yoshuawuyts
Copy link
Contributor Author

doneeeee! - should be all working now ✨

@yoshuawuyts yoshuawuyts mentioned this pull request Nov 15, 2016
3 tasks
@ahdinosaur
Copy link
Member

woo nice 👍

@yoshuawuyts
Copy link
Contributor Author

Fixed merge conflicts. Waiting for tests to pass and will then merge

@yoshuawuyts yoshuawuyts merged commit 7735809 into master Nov 16, 2016
@yoshuawuyts yoshuawuyts deleted the insert-css branch November 16, 2016 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants