-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backend packages #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, typing them out here because there isn't a great place to comment in the diff.
- The test data at
tests/data/joplin
probably isn't used anywhere, but maybe its nice to keep around? - Can remove the
alembic
exclude from thefind_namespace_packages
call insetup.py
.
I'm starting on the sqlalchemy backend today, if I find anything else I'll add here.
Yeah, it might make sense to keep it around for now. I'm thinking that as we expand the test suite we may want a simple backend mocker that just reads files from a directory. Having these files available would probably make that easier to put together in the future. |
Fixed in 2d72c58 |
NB there have been some changes to backend-specific code that were dropped by 22d6a01, so we will need to go back and backport any of those to the backend-specific repos (if they haven't been backported already). |
Since this appears to have stalled out, I've made an RFC with a plan to finish the backend breakout. Tl;dr: I'm proposing we punt on the separation of responsibilities (e.g. #453) -- while it's a good idea, it's becoming a blocker that's holding the stac-fastapi ecosystem in an undefined state. While we might end up with pain down the road to synchronize the backend repos with the main ones, it's my hope that we can use API breakages v3.0 to solve the separation of concerns in the medium-term. |
Related Issue(s):
Description:
Going forward, the SQLAlchemy and PgSTAC backends will be distributed as separate packages and managed in their own repos (
stac-fastapi-sqlalchemy
andstac-fastapi-pgstac
, respectively). The mainDockerfile
anddocker-compose.yml
have been removed since there is no longer a deployable backend associated with this repo.stac-fastapi.api
,stac-fastapi.types
, andstac-fastapi.extensions
as modules under a singlestac-fastapi
package.Import statements for the individual modules will not change, but downstream applications will need to update their dependency from something like...
PR Checklist:
pre-commit run --all-files
)make test
)make docs
)