Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some pydantic 2.0 DeprecationWarnings #289

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix some pydantic 2.0 DeprecationWarnings #289

merged 1 commit into from
Aug 23, 2024

Conversation

kurtmckee
Copy link
Contributor

Description:

The test suite is throwing many DeprecationWarnings and UserWarnings.

This PR addresses only one class: a pydantic 2.0 DeprecationWarning caused by .dict() calls in the test suite itself.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 self-requested a review August 22, 2024 18:45
jonhealy1
jonhealy1 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonhealy1 jonhealy1 merged commit 1396fce into stac-utils:main Aug 23, 2024
15 checks passed
@kurtmckee kurtmckee deleted the fix-some-warnings branch August 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

@jamesfisher-geo jamesfisher-geo jamesfisher-geo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtmckee @jonhealy1 @jamesfisher-geo