-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for stac-fastapi v3.0.0a release #234
Conversation
All of the filters tests/ functionality is broken |
This is working now with stac-fastapi v3.0.0a #238 |
Some tests are passing locally in docker but failing here |
I have no idea why this started failing after I merged the new changes from main - I will have to figure it our tomorrow ... |
just this I guess |
Can add this issue as related issue: |
@pedro-cf Will this fix that issue? |
yes like I meantioned in the issue:
|
Maybe we should write a test for this? Would you like to be a maintainer of this repo? I sent you an invite just in case. |
@jonhealy1 added |
linting error |
test looks great |
@pedro-cf extra inputs are not permitted in Item - something may need to change in stac-pydantic? |
yes that can be changed: https://docs.pydantic.dev/2.7/api/config/#pydantic.config.ConfigDict.extra but should it ? Not sure how to proceeed here, maybe this should not be allowed? kinda loses the point of this plugin though: https://github.com/stac-extensions/web-map-links |
perhaps it's best to revert this test |
Let's revert the test for now and talk about this in #247. I think this is an issue with stac-pydantic according to this - https://schemas.stacspec.org/v1.0.0/item-spec/json-schema/item.json - it should work |
Related Issue(s):
Description:
Update stac-fastapi parent libraries to v3.0.0a. There are quite a few changes made in this pr.
PR Checklist:
pre-commit run --all-files
)make test
)