-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection update endpoint #177
Collection update endpoint #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good. What do you think about writing a test?
…tac-fastapi-elasticsearch into collection_update_endpoint
@jonhealy1 I've added a couple of tests let me know if there are anymore that you think should be added. |
Great thank you. I will do a final review tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Related Issue(s):
Description:
Allow collections to be updated without the deletion of all sub items. If collection id is changed id of the existing collection must be present in the query parameters as
collection_id
.Use case:
Adding a new item to a collection adds a new variable to collection summary/changes extent.
Current workflow:
New workflow:
PR Checklist:
pre-commit run --all-files
)make test
)