Preserve relative links when using from_file
#972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/838-preserve-relative-hrefs
branch
2 times, most recently
from
49974ef to
197ad97
Compare
I don't love the name "prebuilt" but I can't think of a better one.
gadomski
force-pushed
the
issues/838-preserve-relative-hrefs
branch
from
197ad97 to
247d27c
Compare
Codecov ReportBase: 90.13% // Head: 90.13% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 47 47
Lines 6164 6164
Branches 923 923
=======================================
Hits 5556 5556
Misses 426 426
Partials 182 182 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Closing, as this test wasn't exactly the issue from OP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
When reading Catalogs/Collections from files, a user should be able to preserve any relative links e.g. to children. Otherwise, re-saving the Catalog/Collection may produce surprising results (e.g. filesystem-absolute links where previously they were relative, breaking portability).
This is currently a draft PR demonstrating the problem. The fix will likely be adding a
catalog_typeargument tofrom_file, but we should explore other options as well, since adding a new argument to such a widely used classmethod is not ideal.PR Checklist:
pre-commit run --all-files)scripts/test)