Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Storage Extension #745

Merged
merged 6 commits into from
Feb 22, 2022

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Feb 4, 2022

Related Issue(s):

Description:

Implements the Storage Extension, including tests + docs.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb added the extension Implement a STAC extension in PySTAC label Feb 4, 2022
@duckontheweb duckontheweb added this to the 1.4.0 milestone Feb 4, 2022
@duckontheweb duckontheweb changed the title Add/734 storage extension Implement Storage Extension Feb 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #745 (f88541e) into main (dfc1cc2) will increase coverage by 0.12%.
The diff coverage is 99.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   94.39%   94.51%   +0.12%     
==========================================
  Files          77       79       +2     
  Lines       11292    11582     +290     
  Branches     1343     1366      +23     
==========================================
+ Hits        10659    10947     +288     
- Misses        455      457       +2     
  Partials      178      178              
Impacted Files Coverage Δ
pystac/__init__.py 100.00% <ø> (ø)
pystac/extensions/eo.py 93.15% <ø> (ø)
pystac/extensions/storage.py 98.26% <98.26%> (ø)
tests/extensions/test_storage.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc1cc2...f88541e. Read the comment docs.

@duckontheweb duckontheweb merged commit 94eb97c into stac-utils:main Feb 22, 2022
@duckontheweb duckontheweb deleted the add/734-storage-extension branch February 22, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Implement a STAC extension in PySTAC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Storage Extension
3 participants