Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No self links in relative published items #725

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jan 21, 2022

Related Issue(s):

Description:

Fixes issue where self links were included in Items for "relative published" catalogs.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb added this to the 1.4.0 milestone Jan 21, 2022
@duckontheweb duckontheweb requested a review from gadomski January 21, 2022 21:15
@duckontheweb
Copy link
Contributor Author

cc: @scottyhq

@duckontheweb
Copy link
Contributor Author

@volaya Looks like you may have been the last to touch this section of code, so if you want to review that would be appreciated as well. Thanks!

@duckontheweb duckontheweb changed the title Fix/597 self links in relative published items No self links in relative published items Jan 21, 2022
@duckontheweb duckontheweb merged commit d659185 into stac-utils:main Jan 24, 2022
@duckontheweb duckontheweb deleted the fix/597-self-links-in-relative-published-items branch January 24, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catalog.save(dest_href) has unexpected results for pystac.CatalogType.RELATIVE_PUBLISHED
2 participants