-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instance attribute annotations to all classes #705
Add instance attribute annotations to all classes #705
Conversation
@l0b0 Since you've done so much work on type hints in this library it would be great to get your input as well. |
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 94.20% 94.25% +0.05%
==========================================
Files 77 77
Lines 11120 11217 +97
Branches 1337 1337
==========================================
+ Hits 10476 10573 +97
Misses 466 466
Partials 178 178
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Related Issue(s):
Description:
Adds type annotations for instance attributes for all classes. Where the class docstring had an
Attributes
section, I removed those and added a docstring on each type annotation.PR Checklist:
pre-commit run --all-files
)scripts/test
)