Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Point Cloud Extension #558

Merged

Conversation

duckontheweb
Copy link
Contributor

@duckontheweb duckontheweb commented Jul 14, 2021

Related Issue(s):

I've intentionally left #518 for a separate PR that includes all extension name changes.

Description:

  • Updates docstrings and adds Collection summaries for Point Cloud Extension

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob July 14, 2021 21:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #558 (b31cd77) into main (77f203e) will increase coverage by 0.06%.
The diff coverage is 96.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   94.43%   94.50%   +0.06%     
==========================================
  Files          71       71              
  Lines       10611    10703      +92     
  Branches     1092     1095       +3     
==========================================
+ Hits        10021    10115      +94     
+ Misses        420      418       -2     
  Partials      170      170              
Impacted Files Coverage Δ
pystac/extensions/pointcloud.py 95.50% <93.82%> (+0.46%) ⬆️
tests/extensions/test_pointcloud.py 100.00% <100.00%> (ø)
pystac/utils.py 95.27% <0.00%> (+1.57%) ⬆️
pystac/errors.py 95.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f203e...b31cd77. Read the comment docs.

@duckontheweb duckontheweb force-pushed the update/pointcloud-extension branch from 3e7912f to b31cd77 Compare July 15, 2021 14:54
@duckontheweb duckontheweb merged commit 660fd9a into stac-utils:main Jul 15, 2021
@duckontheweb duckontheweb deleted the update/pointcloud-extension branch July 17, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants