Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused locals #519

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jul 6, 2021

Related Issue(s): #331

Description:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #519 (0b8dd59) into main (f2afd5a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   94.25%   94.25%   -0.01%     
==========================================
  Files          71       71              
  Lines       10269    10263       -6     
  Branches     1072     1072              
==========================================
- Hits         9679     9673       -6     
  Misses        422      422              
  Partials      168      168              
Impacted Files Coverage Δ
pystac/catalog.py 91.60% <ø> (ø)
pystac/extensions/label.py 93.67% <ø> (-0.02%) ⬇️
pystac/serialization/common_properties.py 79.62% <ø> (-0.73%) ⬇️
pystac/validation/schema_uri_map.py 75.34% <ø> (-0.98%) ⬇️
pystac/extensions/base.py 90.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2afd5a...0b8dd59. Read the comment docs.

@l0b0 l0b0 force-pushed the chore/remove-unused-locals branch from 7db87b7 to e9787d4 Compare July 8, 2021 01:35
l0b0 added 3 commits July 8, 2021 14:31
It's needed for type checking, but the value is not used in production.
These variables are always overwritten before use.
@l0b0 l0b0 force-pushed the chore/remove-unused-locals branch from e9787d4 to 0b8dd59 Compare July 8, 2021 02:32
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the clean-up work you are doing!

@duckontheweb duckontheweb merged commit e7f404c into stac-utils:main Jul 8, 2021
@l0b0 l0b0 deleted the chore/remove-unused-locals branch July 9, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants