Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Trust method signature to be accurate #516

Merged

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jul 6, 2021

Catalog.get_all_items is contracted to return Iterable[Item], so we
shouldn't have to filter the response.

Related Issue(s): #331

Description:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

`Catalog.get_all_items` is contracted to return `Iterable[Item]`, so we
shouldn't have to filter the response.
@codecov-commenter
Copy link

Codecov Report

Merging #516 (833e990) into main (a4fe4cd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   93.96%   93.97%   +0.01%     
==========================================
  Files          71       71              
  Lines        9991     9991              
  Branches     1061     1060       -1     
==========================================
+ Hits         9388     9389       +1     
  Misses        434      434              
+ Partials      169      168       -1     
Impacted Files Coverage Δ
tests/test_item.py 100.00% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fe4cd...833e990. Read the comment docs.

@lossyrob lossyrob merged commit 5b8b44e into stac-utils:main Jul 7, 2021
@l0b0 l0b0 deleted the tests/trust-method-signature-to-be-accurate branch July 7, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants