Increase test coverage #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 95.54% 95.65% +0.10%
==========================================
Files 71 71
Lines 10008 9979 -29
==========================================
- Hits 9562 9545 -17
+ Misses 446 434 -12
Continue to review full report at Codecov.
|
duckontheweb
approved these changes
Jun 30, 2021
This subtracts from coverage, and it's not much of a time saver: `python tests/extensions/test_version.py` isn't much less typing than `python -m unittest tests/extensions/test_version.py`.
`if not is_valid` can't happen, because `is_valid = not is_absolute_href(asset.href)` and the condition above that line is `if not is_absolute_href(asset.href):`. Conversely, since `is_valid` is always `True` there is no point in `self.assertTrue(is_valid)`.
Presumably versions < 0.8 are no longer supported.
l0b0
force-pushed
the
increase-test-coverage
branch
from
e5abc06 to
de29122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #331
Description:
PR Checklist:
pre-commit run --all-files)scripts/test)