Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Include tests in coverage metric #493

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jun 29, 2021

Missing coverage in tests means unreached (and usually unreachable) test
code, often indicating a test bug.

Related Issue(s): #331

Description:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Missing coverage in tests means unreached (and usually unreachable) test
code, often indicating a test bug.
@codecov-commenter
Copy link

Codecov Report

Merging #493 (3e5fed6) into main (f9573f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          40       40           
  Lines        5245     5245           
=======================================
  Hits         4808     4808           
  Misses        437      437           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9573f8...3e5fed6. Read the comment docs.

@duckontheweb duckontheweb merged commit bfb2e10 into stac-utils:main Jun 29, 2021
@l0b0 l0b0 deleted the include-tests-in-coverage-metric branch June 29, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants