Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Exclude mypy-specific code from coverage #492

Merged

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Jun 29, 2021

Related Issue(s): #331

Description:

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@codecov-commenter
Copy link

Codecov Report

Merging #492 (1fd4c4b) into main (f9573f8) will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   91.66%   92.10%   +0.43%     
==========================================
  Files          40       40              
  Lines        5245     5206      -39     
==========================================
- Hits         4808     4795      -13     
+ Misses        437      411      -26     
Impacted Files Coverage Δ
pystac/collection.py 95.88% <0.00%> (+0.37%) ⬆️
pystac/stac_object.py 95.18% <0.00%> (+0.47%) ⬆️
pystac/catalog.py 95.21% <0.00%> (+0.48%) ⬆️
pystac/serialization/identify.py 93.65% <0.00%> (+0.68%) ⬆️
pystac/summaries.py 79.73% <0.00%> (+0.89%) ⬆️
pystac/serialization/migrate.py 88.52% <0.00%> (+1.22%) ⬆️
pystac/extensions/hooks.py 87.71% <0.00%> (+1.27%) ⬆️
pystac/stac_io.py 84.11% <0.00%> (+1.35%) ⬆️
pystac/cache.py 95.72% <0.00%> (+1.55%) ⬆️
pystac/layout.py 94.97% <0.00%> (+2.03%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9573f8...1fd4c4b. Read the comment docs.

@l0b0
Copy link
Contributor Author

l0b0 commented Jun 29, 2021

This needs to be re-run because of a flaky test.

@duckontheweb duckontheweb merged commit bb8db04 into stac-utils:main Jun 29, 2021
@l0b0 l0b0 deleted the exclude-mypy-specific-code-from-coverage branch June 29, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants